>From Michael Blow <[email protected]>: Attention is currently required from: Ali Alsuliman, Ritik Raj.
Michael Blow has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21213?usp=email ) Change subject: [ASTERIXDB-3768][CLOUD] Add per-link S3 checksumBehavior parameter ...................................................................... Patch Set 2: (3 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21213/comment/59068845_40e057fd?usp=email : PS2, Line 13: ext-ref ```suggestion Ext-ref: MB-71732 ``` File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21213/comment/860e8e06_db067035?usp=email : PS2, Line 148: return new S3ClientConfig(region, endPoint, prefix, anonymousAuth, certificates, profilerLogInterval, : writeBufferSize, 1, 0, 0, 0, false, false, 0, 0, -1, S3ParallelDownloaderClientType.ASYNC, false, "", : "", checksumBehavior); it seems your AI friend opted to inline the external data constructor instead of introduce the checksumBehavior argument there as well- let's keep the using the old constructor here as well. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21213/comment/d0cd4b8e_d4ed7a6e?usp=email : PS2, Line 733: /** : * Resolves the effective checksum behavior for external data (link) operations using a two-level priority chain: : * <ol> : * <li>Per-link {@code checksumBehavior} parameter in the configuration map (explicit override)</li> : * <li>Endpoint-based default: {@link S3ChecksumBehavior#AUTO} for native AWS S3, : * {@link S3ChecksumBehavior#WHEN_REQUIRED} for S3-compatible storage</li> : * </ol> : * Cloud properties are intentionally not consulted here — this method is for external data (link) operations : * only, not for blob storage. : */ this fancy comments seem AI generated, please add the appropriate `@AiProvenenace` annotations where appropriate -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21213?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: Id8fd6405c4aec2a79f469259339d4584612e2479 Gerrit-Change-Number: 21213 Gerrit-PatchSet: 2 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Mon, 11 May 2026 11:02:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
