>From Ian Maxon <[email protected]>: Attention is currently required from: Calvin Thomas Dani.
Ian Maxon has posted comments on this change by Calvin Thomas Dani. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159?usp=email ) Change subject: [ASTERIXDB-3760] Training VTree index ...................................................................... Patch Set 5: (7 comments) File asterixdb/asterix-common/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/6d240f7a_554453a2?usp=email : PS5, Line 205: <version>0.3.10-SNAPSHOT</version> should use the ${project.version} variable here File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SampleOperationsHelper.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/3e34f7ff_1f1e8e6c?usp=email : PS5, Line 177: // @Override why's this not overridden now? File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryVectorOperationsHelper.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/c5ba8d3d_e325ccc5?usp=email : PS5, Line 236: sampleSize = Math.max(sampleSize, 10000); : sampleSize = Math.min(sampleSize, 1000000); would be nice to have these as config options set at their respective values as default rather than being hardcoded https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/84aae9f7_21ec9733?usp=email : PS5, Line 425: UUID permitUUID = UUID.randomUUID(); : UUID materializedDataUUID = UUID.randomUUID(); these UUIDs aren't used anymore right? File asterixdb/asterix-runtime/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/ad07007a_5d2ef182?usp=email : PS5, Line 176: <version>0.3.10-SNAPSHOT</version> same here about the version variable File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/QuantizationConstantsAggregateDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/d09ce435_e64f8b87?usp=email : PS5, Line 131: TEMPORARY should this still be here? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/2bf79dbd_df31e83b?usp=email : PS5, Line 292: ystem.err.println should migrate this to LOGGER::trace or something -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1264840ffd536d91c0ee11634abfd35a0ad79ecd Gerrit-Change-Number: 21159 Gerrit-PatchSet: 5 Gerrit-Owner: Calvin Thomas Dani <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Calvin Thomas Dani <[email protected]> Gerrit-Comment-Date: Mon, 18 May 2026 19:33:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
