>From Preetham Poluparthi <[email protected]>:
Attention is currently required from: Preetham Poluparthi.
Hello Anon. E. Moose #1000171, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21334?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Contrib-2 by Anon. E. Moose #1000171
Change subject: [ASTERIXDB-3713][HYR] Fix activity graph self-loop causing hang
on replicate-to-union-all plans
......................................................................
[ASTERIXDB-3713][HYR] Fix activity graph self-loop causing hang on
replicate-to-union-all plans
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
When ExtractCommonOperatorsRule extracted a common subplan shared by two
branches of a UNION ALL — where one branch went through a HashPartitionExchange
and the other used a direct OneToOne path — the BFS-based SuperActivity
grouping incorrectly merged the Replicate operator and the UnionAll operator
into the same SuperActivity via the OneToOne path. This turned the MToN
HashPartition connector between them into a self-loop on the SuperActivity,
which caused a deadlock.
This patch replaces the BFS expansion with a DFS backward traversal from sink
activities, eliminating the external self-loop that caused the deadlock. As a
result, the isUnionAllSink guard in ExtractCommonOperatorsRule — which was a
band-aid that prevented ACGRewriter from generating the problematic topology —
is no longer needed and is removed.
Ext-ref: MB-70862
Change-Id: Ib521f376c3540db2cfc23c1afdb5370d61c8eb7d
---
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonOperatorsRule.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/ActivityClusterGraphRewriter.java
2 files changed, 97 insertions(+), 101 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/34/21334/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21334?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ib521f376c3540db2cfc23c1afdb5370d61c8eb7d
Gerrit-Change-Number: 21334
Gerrit-PatchSet: 3
Gerrit-Owner: Preetham Poluparthi <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Attention: Preetham Poluparthi <[email protected]>
