>From Calvin Thomas Dani <[email protected]>: Attention is currently required from: Ali Alsuliman, Ian Maxon.
Calvin Thomas Dani has posted comments on this change by Calvin Thomas Dani. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email ) Change subject: [ASTERIXDB-3676] Vector Distance Functions ...................................................................... Patch Set 29: (7 comments) File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/ea448a42_a7064005?usp=email : PS19, Line 138: public boolean isNumericType() { > Acknowledged Done File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/VectorDistanceArrCalculation.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/b58a5fcb_4b422286?usp=email : PS17, Line 22: VectorDistanceArrCalculation > Acknowledged Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/ff009a69_4631765f?usp=email : PS17, Line 36: euclidean_squared > Acknowledged Done File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/VectorDistanceArrCalculation.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/f1c84f31_dbbe8a78?usp=email : PS19, Line 28: sum += diff * diff; > Overflow: IEEE turns huge results into Infinity, Underflow: Tiny values fade > toward 0; Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/14748d10_ec426b7c?usp=email : PS19, Line 30: if (Double.isNaN(sum)) { > Acknowledged Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/38fe9e45_6d9cba78?usp=email : PS19, Line 37: double sum = 0.0; : for (int i = 0; i < a.length; i++) { : double diff = a[i] - b[i]; : sum += diff * diff; : } : if (Double.isNaN(sum)) { : return Double.NaN; // Handle NaN case : } > Acknowledged Done File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/VectorDistanceArrCalculation.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/17e4cc2f_e15eece1?usp=email : PS22, Line 33: if (a.length != b.length) { : throw new IllegalArgumentException("Vectors must be of the same length"); : } > Acknowledged Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I45176e7da13ed222f48bb36bd1f0ab4074a0bcb9 Gerrit-Change-Number: 20126 Gerrit-PatchSet: 29 Gerrit-Owner: Calvin Thomas Dani <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Wed, 10 Jun 2026 17:37:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Calvin Thomas Dani <[email protected]> Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]>
