>From Murtadha Hubail <[email protected]>: Attention is currently required from: Ali Alsuliman, Murtadha Hubail, Rithwik Koul.
Murtadha Hubail has posted comments on this change by Rithwik Koul. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328?usp=email ) Change subject: [ASTERIXDB-3183][COMP] Add query plan cache ...................................................................... Patch Set 45: (9 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMetrics.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/54180940_5a88f0d9?usp=email : PS45, Line 122: cachedPlan isCachedPlan File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/3f47c97e_2cc6df4e?usp=email : PS45, Line 4670: // Interface (IStatementExecutor) entry point: no result metadata and no cached plan. Delegates to the : // cache-aware overload below (used by handleQuery's miss/hit paths). ? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/2a77ebe5_f2e6365d?usp=email : PS45, Line 5675: rewriteCompileQuery I feel like this path should be shared with cache miss File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/5ab6edf6_d33c5b9d?usp=email : PS45, Line 2903: protected void clearCache() throws Exception { : HttpUriRequest method = constructDeleteMethod(getEndpoint(Servlets.PLAN_CACHE), Collections.emptyList()); : HttpResponse response = executeHttpRequest(method); : if (response.getStatusLine().getStatusCode() != HttpStatus.SC_OK) { : throw new Exception("HTTP error " + response.getStatusLine().getStatusCode() + ":\n" + response); : } : } revert File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cache/IQueryCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/69a03679_5b21b7ed?usp=email : PS45, Line 22: (raw request text + plan-affecting inputs) t This shouldn't be in the interface as it's implementation dependent https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/f2836387_0e198280?usp=email : PS45, Line 38: void clear(); Remove one of these https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/733a9ec8_b051c377?usp=email : PS45, Line 45: int size(); remove if not used File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cache/QueryCacheKey.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/edd8f48a_d95b0f88?usp=email : PS45, Line 48: String discriminator we should not implement this like this. File hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/api/ICompiler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/83680c46_9f0fe8c2?usp=email : PS45, Line 41: the query plan cache : * retains it so a hit can call {@link #createJob} without re-optimizing. Remove it -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I116e5fa9d16e5c4a5cc6dfbdf8db230221086a9d Gerrit-Change-Number: 21328 Gerrit-PatchSet: 45 Gerrit-Owner: Rithwik Koul <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Rithwik Koul <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Thu, 25 Jun 2026 12:54:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
