>From Hongyu Shi <[email protected]>: Attention is currently required from: Ian Maxon.
Hongyu Shi has posted comments on this change by Hongyu Shi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21100?usp=email ) Change subject: [ASTERIXDB-3754] Storage layer of VTree index - patch 2 ...................................................................... Patch Set 13: (3 comments) File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-vtree/src/main/java/org/apache/hyracks/storage/am/lsm/vector/dataflow/LSMVTreeLocalResource.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21100/comment/b8c20d40_299f7475?usp=email : PS5, Line 67: ".quantization_ > maybe this should be in AbstractLSMIndexFileManager Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21100/comment/5a4902a3_877f0ee0?usp=email : PS5, Line 383: // ==================== Public Getter Methods for Quantization Parameters ==================== > kinda excessive comment maybe Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-vtree/src/main/java/org/apache/hyracks/storage/am/lsm/vector/dataflow/QuantizedIndexCreateOperatorDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21100/comment/6122448a_eb73e9c0?usp=email : PS5, Line 91: System.err.println("[QuantizedIndexCreateOp] nextFrame() - received frame with " + tupleCount + " tuples"); > if these statements using System.err need to be logged they need to be > through LOGGER. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21100?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I87c468c14cbeb3e698742429ee62df02c8e83efe Gerrit-Change-Number: 21100 Gerrit-PatchSet: 13 Gerrit-Owner: Hongyu Shi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Wed, 01 Jul 2026 21:51:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]>
