>From Rithwik Koul <[email protected]>: Attention is currently required from: Ali Alsuliman, Ian Maxon, Murtadha Hubail, Murtadha Hubail.
Rithwik Koul has posted comments on this change by Rithwik Koul. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328?usp=email ) Change subject: [ASTERIXDB-3183][COMP] Add query plan cache ...................................................................... Patch Set 59: Code-Review+1 (11 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/01fd68c0_51067856?usp=email : PS59, Line 154: plancache > Let's fix this name Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/6370bbd5_b87ef1a2?usp=email : PS59, Line 155: private CompiledPlan lastCompiledPlan; > why the gap? Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceRequestParameters.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/276a0a50_96a303b0?usp=email : PS59, Line 69: plancache > Let's fix this name Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/d78e45aa_6a1da264?usp=email : PS59, Line 5670: ignoreCache > Should this be just calculated inside resolveQuery.. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/f6d96937_d3db53dc?usp=email : PS59, Line 5682: CacheMissResult > I still don't like this, but you can leave it and maybe refactor it at a > later point Acknowledged https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/d5d285c7_47ed3669?usp=email : PS59, Line 5734: warnings.removeIf(preExisting::contains); > You need a comment to "why" you are doing this Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cache/IQueryPlanCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/c838fa98_37d3f42d?usp=email : PS59, Line 24: IQueryPlanCache > Add java docs Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cache/IQueryPlanCacheKey.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/7efc5c13_41734d8b?usp=email : PS59, Line 28: IQueryPlanCacheKey > Add java docs. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/20850e29_b05c8fb3?usp=email : PS59, Line 34: optimize > I don't think you need those getters here the getters are getting used in /Users/rithwik.koul/Desktop/Couchbase/cb1/analytics/cbas/cbas-connector/src/main/java/com/couchbase/analytics/lang/CBStatementExecutor.java and I've added the java docs File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cache/IQueryPlanCacheValue.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/bf0939c1_6b2d1f70?usp=email : PS59, Line 31: IQueryPlanCacheValue > Add java docs Done File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/49fa90f1_f95c55d1?usp=email : PS59, Line 76: // TODO (GLENN): base default capacity off of available memory? > Remove this Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I116e5fa9d16e5c4a5cc6dfbdf8db230221086a9d Gerrit-Change-Number: 21328 Gerrit-PatchSet: 59 Gerrit-Owner: Rithwik Koul <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Rithwik Koul <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Fri, 03 Jul 2026 09:08:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Murtadha Hubail <[email protected]>
