>From Ian Maxon <[email protected]>: Attention is currently required from: Murtadha Hubail, Ritik Raj.
Ian Maxon has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372?usp=email ) Change subject: [ASTERIXDB-3788][STO] flush .dic LAF pages in ascending page-id order ...................................................................... Patch Set 4: (3 comments) Patchset: PS3: > Yes, I used claude, and Opus did write those wordy comments. shouldn't there be @AiProvenance tags and/or a Generated-by/Co-authored-by: in the commit msg? File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/LAFWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372/comment/e29a7022_f37dc589?usp=email : PS3, Line 186: flushReadyPages(); > When page P is underfull, subsequently filled pages in the range (P, > maxPageId] remain held in memor […] mmm yeah i guess it is as well behaved as the caller is (i.e. if you write only sequentially, the dictionary file will never confiscate more than 1 page), and holds a tiny proportion of pages https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372/comment/62334d51_022e7ad7?usp=email : PS3, Line 215: The local file is : * random-access and indifferent to order; only the cloud copy needs this guarantee. > Yes, the pages are flushed sequentially here. […] i guess it's sort of a nit but imo it would be an issue either way. LSM is supposed to be append only since a long time ago, whether or not there's something enforcing it. similar to the contract between open/nextFrame()/flush()/close() in IFrameWriter. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2a8a83cd1b57d3ceb1d9be381edd6589a0e138b9 Gerrit-Change-Number: 21372 Gerrit-PatchSet: 4 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Sat, 04 Jul 2026 02:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Ritik Raj <[email protected]>
