>From Ali Alsuliman <[email protected]>: Attention is currently required from: Calvin Thomas Dani, Ian Maxon.
Ali Alsuliman has posted comments on this change by Calvin Thomas Dani. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email ) Change subject: [ASTERIXDB-3676] Vector Distance Functions ...................................................................... Patch Set 40: Code-Review+2 (2 comments) File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppVectorDistanceRewriteVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/a8fbc4ad_deb10d26?usp=email : PS40, Line 43: public final class SqlppVectorDistanceRewriteVisitor extends AbstractSqlppSimpleExpressionVisitor { Is it possible to include this logic in `SqlppFunctionCallResolverVisitor`? File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/2cef0dee_e3195abb?usp=email : PS40, Line 1934: addFunction(EUCLIDEAN_DISTANCE, ADoubleTypeComputer.INSTANCE, true); I think you missed my earlier comment to make it back as INSTANCE_NULLABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I45176e7da13ed222f48bb36bd1f0ab4074a0bcb9 Gerrit-Change-Number: 20126 Gerrit-PatchSet: 40 Gerrit-Owner: Calvin Thomas Dani <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Calvin Thomas Dani <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 22:10:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
