Till Westmann has posted comments on this change. Change subject: Send Bad-request response on failure of decoding query string ......................................................................
Patch Set 1: (1 comment) Add a test case? https://asterix-gerrit.ics.uci.edu/#/c/1602/1/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java: PS1, Line 88: DefaultHttpResponse badRequest = : new DefaultHttpResponse(request.protocolVersion(), HttpResponseStatus.BAD_REQUEST); : ctx.write(badRequest).addListener(ChannelFutureListener.CLOSE); Should we have a single method (e.g. respondWithStatus) that takes a status code and does the rest? -- To view, visit https://asterix-gerrit.ics.uci.edu/1602 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aa000e469392a5e4b079b331472edd0dc4f65a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
