abdullah alamoudi has posted comments on this change. Change subject: Remove static cc application context instance ......................................................................
Patch Set 2: > High-level comments: > > What's the motivation for this change? > > If appCtx is now a property of the QueryTranslator, and this is the > way to access the active handler and listener, the IExtension > statement needs some way to access this property, otherwise > extension statements can't get to the listener or handler Response to high level comment: Some of the bad side effects of app context info are: 1. it is a static class that gets accessed sometimes from NCs while it shouldn't. 2.it is a static class that causes testing to behave differently in execution tests from integration tests. 3.it will create more testing problems when we move to multiple compilation nodes. 4.it is being used as a hack to do some things easily rather than correctly. as for accessing the handler in extension statements, they have reference to both statement executor and metadata provider and can get it from either. -- To view, visit https://asterix-gerrit.ics.uci.edu/1606 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2e250405967ec880e7af6387aa981f39b3392c0 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: No
