Xikui Wang has posted comments on this change. Change subject: Fix Pre-Distributed Jobs ......................................................................
Patch Set 3: (2 comments) Not sure about my interface change comment. Maybe @Yingyi can have a look at it. :) https://asterix-gerrit.ics.uci.edu/#/c/1656/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetManager.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetManager.java: Line 29: public long getStateTimestamp(JobId jobId); I see your point here. The only usage is, like you said, the get timestamp. There are a lot of information in the StateRecord though. I lean toward not to change interface unless we are sure that is not useful. Let's what others think. :) https://asterix-gerrit.ics.uci.edu/#/c/1656/3/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/PredistributedJobsTest.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/PredistributedJobsTest.java: Line 148: Thread.sleep(180000); Please correct me if I'm wrong. The sweeper period is controlled by Option.RESULT_SWEEP_THRESHOLD in NCConfig, which is 60000 now. This option can be changed by setResultSweepThreshold. Can we set it to 10s or 15s to minimize the sleep time here? (The build process is absurdly long already... wanna see if we can make it shorter...) -- To view, visit https://asterix-gerrit.ics.uci.edu/1656 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id50c52fbc7c891761dcabd654fb9b853b5f7a91d Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Ildar Absalyamov <ildar.absalya...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
