Akshay Manchale has posted comments on this change.

Change subject: Adding docker support for writing replication ITs
......................................................................


Patch Set 5:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1644/3/asterixdb/asterix-installer/pom.xml
File asterixdb/asterix-installer/pom.xml:

PS3, Line 309:      
> tabs?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1644/3/asterixdb/asterix-installer/src/test/resources/docker/Dockerfile
File asterixdb/asterix-installer/src/test/resources/docker/Dockerfile:

PS3, Line 44: OPY 
> remove commented code?
Done


PS3, Line 53: 
> remove commented code?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1644/3/asterixdb/asterix-installer/src/test/resources/docker/cluster-config.xml
File asterixdb/asterix-installer/src/test/resources/docker/cluster-config.xml:

PS3, Line 21: asterix
> This is not related to the Vagrant software, is it?
Done


PS3, Line 76: 
> What is this 'q' good for?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1644
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7948a25f39e1c155ce96502572c1eef122f04bf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Akshay Manchale <akshaym...@gmail.com>
Gerrit-Reviewer: Akshay Manchale <akshaym...@gmail.com>
Gerrit-Reviewer: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Reply via email to