Yingyi Bu has posted comments on this change. Change subject: Cleanup storage exceptions ......................................................................
Patch Set 8: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1619/8/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java: PS8, Line 678: Exception No remote exception thrown from here? PS8, Line 867: Exception no remote exception thrown? https://asterix-gerrit.ics.uci.edu/#/c/1619/7/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/NodeGroupTupleTranslator.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/NodeGroupTupleTranslator.java: Line 81: List<String> nodeNames = new ArrayList<>(); > MAJOR SonarQube violation: fix this? https://asterix-gerrit.ics.uci.edu/#/c/1619/8/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/NodeGroupTupleTranslator.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/NodeGroupTupleTranslator.java: Line 81: List<String> nodeNames = new ArrayList<>(); > MAJOR SonarQube violation: Fix this? https://asterix-gerrit.ics.uci.edu/#/c/1619/8/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexExamplesTest.java File hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexExamplesTest.java: PS8, Line 739: The code in the three if-else-if branches are exactly the same, can you unify the if condition? if(e.getErrorCode() != ErrorCode.UNSORTED_LOAD_INPUT || e.getErrorCode() == ErrorCode.DUPLICATE_KEY|| e.getErrorCode() == ErrorCode.DUPLICATE_LOAD_INPUT ){ .... } else{ throw e; } I had that comment on PatchSet 4. -- To view, visit https://asterix-gerrit.ics.uci.edu/1619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I020d2b4b1f4ae48fc2df0b720e70a1ce95867d34 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
