Till Westmann has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline ......................................................................
Patch Set 13: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1618/13/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/AbstractFrameWriter.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/AbstractFrameWriter.java: PS13, Line 29: AbstractFrameWriter Could we add a comment here describing the division of labor between the AbstractFrameWriter and the subclasses? E.g. what belongs into the doXxx() methods and what shouldn't be there? -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
