Xikui Wang has posted comments on this change. Change subject: Add install/uninstall UDF to Ansible ......................................................................
Patch Set 1: (4 comments) Fixed the SQ comments and the fixed dataverse and libname mistake. https://asterix-gerrit.ics.uci.edu/#/c/1682/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java: Line 58: private static final FilenameFilter nonHiddenFileNameFilter = ((dir, name) -> !name.startsWith(".")); > Fix this? Done https://asterix-gerrit.ics.uci.edu/#/c/1682/1/asterixdb/asterix-server/src/main/opt/ansible/bin/udf.sh File asterixdb/asterix-server/src/main/opt/ansible/bin/udf.sh: PS1, Line 69: test > why "dataverse=test libname=test" is hard coded here? This is an embarrassing mistake. Fixed. https://asterix-gerrit.ics.uci.edu/#/c/1682/1/asterixdb/asterix-server/src/main/opt/ansible/yaml/deploy_udf.yml File asterixdb/asterix-server/src/main/opt/ansible/yaml/deploy_udf.yml: PS1, Line 20: packages > Deploy UDF library {{ dataverse }}.{{ libname }} to the cluster Done https://asterix-gerrit.ics.uci.edu/#/c/1682/1/asterixdb/asterix-server/src/main/opt/ansible/yaml/destroy_udf.yml File asterixdb/asterix-server/src/main/opt/ansible/yaml/destroy_udf.yml: PS1, Line 20: certain > Destroy UDF library {{ libname }} in dataverse {{ dataverse }} Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1682 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7ea9640a06e2b691c19a8a819307d84b55a679e Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
