Michael Blow has posted comments on this change.

Change subject: Ensure Proper Process is Killed With Managix Stop
......................................................................


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1707/3/asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh
File 
asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh:

PS3, Line 20: '{ print $2 }'`
> Isn't $2 the TTY not the PID?
not with -f, PID is $2, PPID is $3


https://asterix-gerrit.ics.uci.edu/#/c/1707/3/asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh
File 
asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh:

PS3, Line 21: 
            : INFO=``
> seems like this isnt used anymore?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1707
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-HasComments: Yes

Reply via email to