Michael Blow has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens ......................................................................
Patch Set 1: (3 comments) Can we add a regression test for this? https://asterix-gerrit.ics.uci.edu/#/c/1713/1/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: PS1, Line 106: . understood there's a lot of inconsistency in other messages, but I don't think we should trailing period (.) for error messages... PS1, Line 106: Input Stream is this referring to a java.io.InputStream? If so I think I'd rename this to InputStream, otherwise lose the capitalization, e.g. Malformed input stream https://asterix-gerrit.ics.uci.edu/#/c/1713/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java: PS1, Line 158: if (th instanceof IOException) { : if (th instanceof RuntimeDataException I would only do one instanceof HyracksException and cast to HyracksException, so that we don't rely on it being the exact type, so long as it has the correct error code. -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-HasComments: Yes
