abdullah alamoudi has posted comments on this change. Change subject: Rename Component Filter Factory ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1779/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/IComponentFilterFactoryAndComparatorFactoriesProvider.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/IComponentFilterFactoryAndComparatorFactoriesProvider.java: PS1, Line 23: IComponentFilterFactoryAndComparatorFactoriesProvider > It will either be casts or declare the concrete thing rather than the inter We can also pass the two interfaces separately when creating the AbstractLsmIndex but.... This will cause the number of parameters to increase and it is already a lot -- To view, visit https://asterix-gerrit.ics.uci.edu/1779 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3d9bef3fb6118c66195630cec23a7e41fc5861 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
