Michael Blow has posted comments on this change. Change subject: Enable Adding Nodes to Running *DB Cluster ......................................................................
Patch Set 6: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1785/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/PropertiesAccessor.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/PropertiesAccessor.java: PS6, Line 246: uniquePartitionId > Wouldn't you want to check for overlapping partition id configuration (i.e. Good point, I will add a check for this. https://asterix-gerrit.ics.uci.edu/#/c/1785/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java: PS6, Line 355: registerNodePartitions > Is this method used anywhere? currently only used by an extension- will either add a test for it or file an issue to track adding a test for it -- To view, visit https://asterix-gerrit.ics.uci.edu/1785 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If978442a95687c00ef78c89ed1b4440f5e308b99 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
