Luo Chen has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index ......................................................................
Patch Set 5: (2 comments) > (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1796/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java: PS5, Line 32: isDelete > why not antimatter? Across code base, I saw some places use isAntimatter (like here), and some other places use isDelete(like the original LSMBTreeReferencingTupleWriterFactory). Just want to make a unified convention of this. If necessary, I can change all places to isAntimatter as well. https://asterix-gerrit.ics.uci.edu/#/c/1796/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentWithBuddyBulkLoader.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentWithBuddyBulkLoader.java: PS5, Line 87: : updateFilter(tuple) > Why update the filter for antimatter? Currently, when we delete a tuple (insert antimatter tuple or insert into the buddy btree) from LSM indexes, we also updated filters (and this should be the correct way). Actually I missed this part in the last patch... -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
