Luo Chen has posted comments on this change. Change subject: Add Disk Component Scan operation for primary LSM index ......................................................................
Patch Set 3: (2 comments) > (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1791/3/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java: PS3, Line 46: LSMBTreeDiskComponentScanCursor > It feels like a lot of this code is shared with the normal cursor. Is that Yes, so it extends LSMIndexSearchCursor for code re-use. Most of work of maintaining the priority queue is done there. However, this scan cursor needs to append extra fields, and generate proper tuples for anti-matter tuples (basically completing the anti-matter tuples, since in the primary BTree we only have the primary key) https://asterix-gerrit.ics.uci.edu/#/c/1791/3/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/LSMOperationType.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/LSMOperationType.java: PS3, Line 28: DISK_COMPONENT_SCAN > I see. Still though, at the base of it, a search is a component scan as wel I was thinking "search" is still a little bit different from "scan" since search often returns tuples satisfying a given predicate, while scan returns everything in that index. In this patch, I didn't allow the caller to set a predicate for this operation (unless there are some valid use cases for doing this). Thus, I think scan might be a better term, what about RAW_SCAN then? -- To view, visit https://asterix-gerrit.ics.uci.edu/1791 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31b2c67c58cb0a440c1d2c26400af322e2f1c1e5 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
