Yingyi Bu created ASTERIXDB-1929: ------------------------------------ Summary: Factor out isAntimatter from TupleWriter and TupleWriterFactory Key: ASTERIXDB-1929 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929 Project: Apache AsterixDB Issue Type: Improvement Components: Storage Reporter: Yingyi Bu Assignee: Chen Luo
isAntimatter is a property of the tuple that we're writing, but not a property of the Writer. Hence, we probably should remove setAntimatter(...) from the TupleWriter. Currently, for each tuple write operation, we need to call setAntimatter() in both TupleWriterFactory and TupleWriter. This is painful and potentially buggy -- a XxxFactory typically is one per NC. Instead, we can add a parameter to write tuple method: public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) -> public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, boolean isDelete) -- This message was sent by Atlassian JIRA (v6.3.15#6346)