Luo Chen has posted comments on this change. Change subject: Add Disk Component Scan operation for primary LSM index ......................................................................
Patch Set 5: (6 comments) > (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1791/4/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties File hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties: PS4, Line 77: secondar > "supported in Secondary LSM Index"-> "allowed for a secondary index" ? Done https://asterix-gerrit.ics.uci.edu/#/c/1791/4/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java: PS4, Line 100: > There are a few null-handling which tries to re-use objects. But I wonder w It seems we will never reuse a disk component scan cursor, since creating a secondary index would create a search cursor from the primary index, and the scan cursor is local to the search cursor. I thus removed the reuse logic. PS4, Line 174: .addFie > throw an exception? Done PS4, Line 239: > return elementA.getCursorIndex() > elementB.getCursorIndex()? -1: 1; Done https://asterix-gerrit.ics.uci.edu/#/c/1791/4/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS4, Line 465: ctx.getSearchOperationCallback().before(null); > So disk component scan doesn't do any locking. I remember that you said t Yes, it still happens. I created a jira to track the issue here https://issues.apache.org/jira/browse/ASTERIXDB-1930 PS4, Line 479: cksDataException.cre > HyracksDataException.create(e); Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1791 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31b2c67c58cb0a440c1d2c26400af322e2f1c1e5 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
