abdullah alamoudi has posted comments on this change. Change subject: Enable Component rollback in LSM Indexes ......................................................................
Patch Set 9: > 4. Based on 1., I don't think the introduction of > ComponentState.DECOMMISSIONING > is necessary. Adding one more state complicate the state machine a > lot. Yingyi, if we don't introduce that state, then we will have to markComponentAsValid while locking or change the logic of marking a component as valid (by adding a further step to add to complete validation and write metadata page). -- To view, visit https://asterix-gerrit.ics.uci.edu/1788 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fe10965734b60776100580c9568a0f954d6cb58 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: No