Ian Maxon has posted comments on this change.

Change subject: Log filter values for redo during recovery
......................................................................


Patch Set 5:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.2.ddl.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.2.ddl.aql:

PS5, Line 52: /* Create dataset for loading raw Fragile data */
            : create dataset Fragile_raw (FragileTypeRaw)
            : primary key row_id;
            : 
            : /* Create dataset for cleaned Fragile data */
            : create dataset Fragile (FragileType)
            : primary key row_id with filter on date;
> Is it possible to use a file feed to directly feed data into the dataset (i
Maybe, but I think for the purpose of this test it's kind of the same either 
way.


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java:

Line 1249:     }
> Which would be the most frequent case? non-filter case? If so, can we chang
Done


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeOpContext.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeOpContext.java:

Line 59:     private PermutingTupleReference logTuple;
> Can we put some comments on this for the future references?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1798
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Jianfeng Jia <[email protected]>
Gerrit-Reviewer: Luo Chen <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Taewoo Kim <[email protected]>
Gerrit-HasComments: Yes

Reply via email to