abdullah alamoudi has posted comments on this change. Change subject: Change DataflowHelperFactory not to require Task Context ......................................................................
Patch Set 5: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1758/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java: PS4, Line 43: ster.INodeManage > Add public methods to the interface? Done PS4, Line 90: String nc = > requestFromNcs -> sendSyncRequestToNCs Yes and we thought someone might use this for some other task :-\ PS4, Line 113: > I think that a RuntimeDataException (or a subclass) might the the right cho Done PS4, Line 125: ) { > error code Done PS4, Line 132: > What's this method used for? Yes :-\ This is used by a response message to deliver a single NC response... https://asterix-gerrit.ics.uci.edu/#/c/1758/4/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: PS4, Line 54: no > one more s? the second s means seconds! -- To view, visit https://asterix-gerrit.ics.uci.edu/1758 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dcd95dbefca131c4bbdb43306f00f6f8ea60800 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
