Michael Blow has submitted this change and it was merged. Change subject: Strip query string from servlet localPath ......................................................................
Strip query string from servlet localPath Path should not contain query string; remove it when extracting localPath from request uri. Change-Id: I0b4942fb1249807fcee9d3047568dc1749798d85 Reviewed-on: https://asterix-gerrit.ics.uci.edu/1819 Sonar-Qube: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> BAD: Jenkins <[email protected]> Reviewed-by: Till Westmann <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; No violations found; No violations found; Verified diff --git a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java index d029bbc..1030686 100644 --- a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java +++ b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java @@ -139,7 +139,8 @@ public String localPath(IServletRequest request) { final String uri = request.getHttpRequest().uri(); - return uri.substring(trim(uri)); + int queryStart = uri.indexOf("?"); + return queryStart == -1 ? uri.substring(trim(uri)) : uri.substring(trim(uri), queryStart); } public String servletPath(IServletRequest request) { -- To view, visit https://asterix-gerrit.ics.uci.edu/1819 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b4942fb1249807fcee9d3047568dc1749798d85 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]>
