Yingyi Bu has posted comments on this change. Change subject: Cleanup Buffer Cache ......................................................................
Patch Set 7: @Abdullah, what I worried about is regression. Currently a user doesn't need to manually ensure txn & iodevice dirs exist. With that change, I'm afraid we will see surprises -- I'm not sure. 1. IMO, at least we shouldn't change that user model -- no need to manually create any dirs -- only specify the path in config. Internally, if we go for the new strict contract, we need to ensure every user-specified path exists, e.g., txn & iodevices, maybe some other ones. 2. I'm not sure if the old convenience API has indeed created some bugs -- if so, can you remind me what were the ASTERIXDB-xxxs? Why can it make things untracked - it is just a sugar? Again, determining whether an index has been created shouldn't rely on the fact that the dir exists but should rely on the metadata transactions? It seems to me that the convenient open(...) is a pretty standard approach as the Linux File API shows. -- To view, visit https://asterix-gerrit.ics.uci.edu/1840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15565b07afdc94ac74c608bfe4480fa09dcf8f1c Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
