Yingyi Bu has posted comments on this change. Change subject: Cleanup Buffer Cache ......................................................................
Patch Set 8: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1840/8/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java: PS8, Line 158: if (fileManager.exists()) { : throw HyracksDataException.create(ErrorCode.CANNOT_CREATE_EXISTING_INDEX); : } > I suspect this potentially might cause bugs/regressions. >>1. For example, drop index was interrupted/cancelled; >>2. the system was crashed while we're dropping index; Oh, these two cases shouldn't be a problem. But interrupted or crashed create index could be a problem. It feels to me that if metadata tells us the index doesn't exist, corresponding file creations on NCs shouldn't fail -- if the file exists, we delete it first. -- To view, visit https://asterix-gerrit.ics.uci.edu/1840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15565b07afdc94ac74c608bfe4480fa09dcf8f1c Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
