Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-1955][CLUS][RT] Refactor, Keep-Alive ......................................................................
Patch Set 4: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1855/3/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java: PS3, Line 124: if (response.status() != HttpResponseStatus.UNAUTHORIZED) { : // since the request failed, we need to close the channel on complete : future.addListener(ChannelFutureListener.CLOSE); : } > what if keepAlive = false and response status = unauthorized? Seems that this would be not any different than when response status = 200. https://asterix-gerrit.ics.uci.edu/#/c/1855/3/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java: PS3, Line 68: fullResponse.headers().remove(HttpHeaderNames.CONNECTION); > This is something we didn't do before (removing the header). just make sure We are not keeping alive (we are about to close the connection), so I think it is right, it may help eliminate EOFs and retries by the client since we prematurely close a Keep-Alive connection. It's not clear to me why we need to close on failure anyway- but that can be addressed in the future. -- To view, visit https://asterix-gerrit.ics.uci.edu/1855 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id75dd55861976390b1098a496ff2c0345c991389 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
