Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-1130][STO]: Jackson serialization for persisted objects ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1850/2/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixVirtualBufferCacheProvider.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixVirtualBufferCacheProvider.java: PS2, Line 21: import com.fasterxml.jackson.annotation.JsonCreator; : import org.apache.asterix.common.api.INcApplicationContext; : import org.apache.hyracks.api.application.INCServiceContext; : import org.apache.hyracks.api.exceptions.HyracksDataException; : import org.apache.hyracks.api.io.FileReference; : import org.apache.hyracks.api.io.IIOManager; : import org.apache.hyracks.api.io.IODeviceHandle; : import org.apache.hyracks.storage.am.lsm.common.api.IVirtualBufferCache; : import org.apache.hyracks.storage.am.lsm.common.api.IVirtualBufferCacheProvider; : : import java.util.List; : I think this import order is counter to what we tend to have, which I think is: java.* javax.* org.* com.* * -- To view, visit https://asterix-gerrit.ics.uci.edu/1850 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icea155fcfdd6a5d9c3d21ce60daa7bb69e206cd7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-HasComments: Yes
