Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for Correlated Datasets ......................................................................
Patch Set 8: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1845/3/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.6.txnqbc.aql File asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.6.txnqbc.aql: PS3, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1845/4/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.6.txnqbc.aql File asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.6.txnqbc.aql: PS4, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1845/7/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.9.txnqar.aql File asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.9.txnqar.aql: PS7, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1845/7/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.6.txnqbc.aql File asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.6.txnqbc.aql: PS7, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1845/7/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.9.txnqar.aql File asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.9.txnqar.aql: PS7, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1845/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexCreationTupleProcessorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexCreationTupleProcessorNodePushable.java: PS7, Line 73: private final FrameTupleReference tuple = new FrameTupleReference(); > Is it necessary to override the superclass field? tuple was remove from the super class AbstractLSMSecondaryIndexCreationNodePushable. The reason is that LSMSecondaryIndexBulkLoadNodePushable needs a permuting tuple, because the incoming tuple might have a different layout (for inverted index after tokenization and rtree with point mbr optimizaiton) -- To view, visit https://asterix-gerrit.ics.uci.edu/1845 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I100fc0b86b8a6fa36a95d77806107bad0307544e Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
