Yingyi Bu has posted comments on this change. Change subject: [TEST] Add performance test for AsterixDB ......................................................................
Patch Set 30: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/prepare_queries.yml File asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/prepare_queries.yml: PS30, Line 24: WS https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/spark_sql_settings.yml File asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/spark_sql_settings.yml: PS30, Line 32: 1024 Make it a ratio to the physical RAM size instead of hardcoded? PS30, Line 48: 2 Make it a ratio to the physical RAM size instead of hardcoded? PS30, Line 50: (small x 2) This part should be dynamically generated from aws_settings.yaml? https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/backup_queries/q18.txt File asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/backup_queries/q18.txt: PS30, Line 18: ------------------------------------------------------------ Can you let the extension name of the file be q18.sql? https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/conf/execute-query.tmpl File asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/conf/execute-query.tmpl: PS30, Line 41: WS https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/conf/ssh_config File asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/conf/ssh_config: PS30, Line 21: Tab->spaces https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/run_sparksql.sh File asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/run_sparksql.sh: PS30, Line 40: sparks "sparks" -> "spark"? PS30, Line 47: ansible-playbook -i $INVENTORY $SCRIPT_PATH/ansible/execute_queries.yml It looks that all queries are only executed once? Can you execute & report them three times like that for AsterixDB? -- To view, visit https://asterix-gerrit.ics.uci.edu/1879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9ff8efa0be71bde67190ba6f9fbd647c7799084 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
