abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2008][CLUS] Only add pending removal if node known ......................................................................
Patch Set 6: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/1921/6/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/SingleThreadEventProcessor.java File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/SingleThreadEventProcessor.java: PS6, Line 45: executorService = Executors.newSingleThreadExecutor(r -> { : executorThread = new Thread(r, threadName); : return executorThread; : }); > No need to create a pool if it will be used for a single thread Done PS6, Line 78: future.cancel(true); > It's better to make a volatile flag and interrupt the thread then join on i Done https://asterix-gerrit.ics.uci.edu/#/c/1921/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java: Line 276: for (Entry<ConnectorDescriptorId, Pair<Pair<IOperatorDescriptor, Integer>, Pair<IOperatorDescriptor, Integer>>> entry : subJob > Yes! Done https://asterix-gerrit.ics.uci.edu/#/c/1921/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java: Line 163: } catch (Throwable th) { > BLOCKER SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1921/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterExecutor.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterExecutor.java: Line 44: > Abdullah: this will go away Done https://asterix-gerrit.ics.uci.edu/#/c/1921/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterRuntimeManager.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterRuntimeManager.java: Line 50: > Abdullah: this will go away Done https://asterix-gerrit.ics.uci.edu/#/c/1921/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java: PS6, Line 116: adapter.fail(); > Not needed. Will fail on start Done PS6, Line 121: adapter.fail(); > Not needed Done https://asterix-gerrit.ics.uci.edu/#/c/1921/6/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/constraints/AlgebricksAbsolutePartitionConstraint.java File hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/constraints/AlgebricksAbsolutePartitionConstraint.java: PS6, Line 41: deepToString > Just return locations.toString Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1921 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7044896559798426c04a3f46861bc5335b25d140 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
