abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2025][STO] Fix Merge Lifecycle ......................................................................
Patch Set 12: > PS, I don't think we need to synchronize on deletion by ourselves. > > 1. Throwing an exception about deleting a non-existing file > doesn't give a user additional information, as long as we log > deletion operations in the log. With an exception on hands, a user > is still not able to find out where the file gets deleted in the > first place. > > 2. Simple solution (i.e., the OS has already serialized file > deletion operations) is easier to understand and maintain. > > 3. If we add ROLL_BACK, there'll be one more thing to synchronize > by ourselves. Had a discussion about this with Mike Carey. we will log warning for double deletion (not fail) but we should still never do it... -- To view, visit https://asterix-gerrit.ics.uci.edu/1930 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I843de8b26c181205e43f4eabe22a7c43f3ebfcbc Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: No
