abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2033][OTH] restrict chunk size in http server ......................................................................
Patch Set 4: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1935/4/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java: PS4, Line 92: LOGGER.log(Level.WARNING, "Unhandled throwable", th); > This is unsafe in case of OOM- at least the log call should be in a try/cat Done https://asterix-gerrit.ics.uci.edu/#/c/1935/4/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java: PS4, Line 57: } else if (len == 0) { : return; > seems like this could be removed... Done PS4, Line 60: int remaining = len; > could reuse len instead of introducing a new local (like w/ off) Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1935 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08bac47ea28f66502b99df6fb8ff91dd85566d38 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
