abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-1990][ASTERIXDB-1991][STO] Log deletion failure ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1926/6/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/IoUtil.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/IoUtil.java: PS6, Line 70: catch (IOException e) { : //TODO (ASTERIXDB-2027: this should eventually be replaced by an exception) : LOGGER.log(Level.WARNING, e.getMessage(), e); : } Let's log FileNotFoundException, and throw otherwise to detect things like disk failure or permission errors early on... -- To view, visit https://asterix-gerrit.ics.uci.edu/1926 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf7c76f0613467ab307eca42f5ac0834a60fa44 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
