Shiva Jahangiri has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON ......................................................................
Patch Set 9: (19 comments) addressed comments https://asterix-gerrit.ics.uci.edu/#/c/1885/9//COMMIT_MSG Commit Message: PS9, Line 7: SITE > SITE is the component for the the website at http://asterixdb.apache.org/, Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java: Line 45: public enum OutputFormat { > It seems that this is not formatted according to our project rules: Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/pom.xml File asterixdb/asterix-app/pom.xml: PS9, Line 284: <version>2.8.4</version> > We should provide a version here, as the version is provided in the asterix Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: PS9, Line 117: private > Please check the formatting here. Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java: Line 123: planFormat = PlanFormat.valueOf(plan); > Hm, this seems like it'd be good to fix somehow. Done Line 127: planFormat = PlanFormat.CLEAN_JSON; > CRITICAL SonarQube violation: Done Line 130: opPlanFormat = PlanFormat.valueOf(opPlan); > CRITICAL SonarQube violation: Done Line 135: opPlanFormat = PlanFormat.CLEAN_JSON; > CRITICAL SonarQube violation: Done PS9, Line 178: IStatementExecutor > Please check the formatting here. Done PS9, Line 197: protected > Please check the formatting here. Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: PS9, Line 256: TODO > Could you file an issue for this? Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java: PS9, Line 112: format > Please check the formatting in this file. Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java: PS9, Line 113: IStatementExecutor > Please check the formatting in this file. Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java: PS9, Line 61: > Seems like this is more or less the same as its optimized counterpart sans Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java: PS9, Line 197: boolean firstPlan = false; > Whats this about? Removed. This was only looking at the first plan before. Now it can handle multiple plans PS9, Line 211: final JsonParser parser = new ObjectMapper().getJsonFactory().createJsonParser(objectActual); : while (parser.nextToken() != null) { : } > So you just want to check if it's a valid JSON object? Yes, cause I am not changing the plan, I just change it to json. https://asterix-gerrit.ics.uci.edu/#/c/1885/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java: PS9, Line 50: UNPARTITIONED > Please check the formatting in this file. Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java: PS9, Line 28: import > As there are no functional changes is this file, it should be reverted to i Done https://asterix-gerrit.ics.uci.edu/#/c/1885/9/hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java File hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java: PS9, Line 35: org > This file should be reverted as well. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Shiva Jahangiri <shi...@uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
