Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2049][ING] Fix hang in Start Feed ......................................................................
Patch Set 1: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1953/1//COMMIT_MSG Commit Message: PS1, Line 14: finishes s/finishes/finishing/ PS1, Line 14: unregisters s/unregisters/unregistering/ PS1, Line 16: never reaches the total number of runtimes Just curious: which code checks that those numbers are the same? PS1, Line 18: we use different counters : for registration and deregistration How does that solve the problem? https://asterix-gerrit.ics.uci.edu/#/c/1953/1/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java: PS1, Line 157: Could be that it finished running locally I don't understand what "running locally" means. Is there another way of describing this? https://asterix-gerrit.ics.uci.edu/#/c/1953/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java: PS1, Line 190: registrations Add a word about what gets registered? https://asterix-gerrit.ics.uci.edu/#/c/1953/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/active/TestNodeControllerActor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/active/TestNodeControllerActor.java: PS1, Line 66: running locally Again, not sure what "running locally" means. -- To view, visit https://asterix-gerrit.ics.uci.edu/1953 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0019f5634009bf924fb37acc78eb796842eef492 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-HasComments: Yes
