Michael Blow has posted comments on this change. Change subject: Un-Singleton ClusterStateManager ......................................................................
Patch Set 3: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1944/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java: PS3, Line 59: ICcApplicationContext appCtx move to 1st param to match super, i would change paths to be vararg... https://asterix-gerrit.ics.uci.edu/#/c/1944/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: PS3, Line 431: ((ICcApplicationContext) appCtx) it seems hacky that the NCQueryServiceServlet extends this class, happens to override this method, since appCtx won't be the right type in that instance. Should we refactor the common parts to an abstract super of QueryServiceServlet, and have NCQueryServiceServlet extend that? (doesn't need to be part of this change, just saying) https://asterix-gerrit.ics.uci.edu/#/c/1944/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java: PS3, Line 56: IApplicationContext ICcApplicationContext, avoid cast later? https://asterix-gerrit.ics.uci.edu/#/c/1944/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java: Line 278: for (Entry<ConnectorDescriptorId, Pair<Pair<IOperatorDescriptor, Integer>, Pair<IOperatorDescriptor, Integer>>> entry : subJob > MAJOR SonarQube violation: +1 https://asterix-gerrit.ics.uci.edu/#/c/1944/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java: PS3, Line 88: IApplicationContext change to ICcApplicationContext, have the caller do the casts.. https://asterix-gerrit.ics.uci.edu/#/c/1944/3/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java: PS3, Line 116: IClusterStateManager csm = appCtx.getClusterStateManager(); : int numNodesInCluster = csm.getParticipantNodes(true).size(); collapse lines? -- To view, visit https://asterix-gerrit.ics.uci.edu/1944 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6532245033ac4c6f6aa9f193539944eecb832f7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
