Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index ......................................................................
Patch Set 12: (6 comments) Please also revert all files that only have formatting changes. https://asterix-gerrit.ics.uci.edu/#/c/1916/12//COMMIT_MSG Commit Message: PS12, Line 20: enforeced enforced https://asterix-gerrit.ics.uci.edu/#/c/1916/12/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj File asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj: PS12, Line 604: indexName = Identifier() ifNotExists = IfNotExists() : | : ifNotExists = IfNotExists() (indexName = Identifier())? Let's only have the index creation option that's consistent with the one above? PS12, Line 613: + WS around the "+"? https://asterix-gerrit.ics.uci.edu/#/c/1916/12/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: PS12, Line 650: indexName = Identifier() ifNotExists = IfNotExists() : | : ifNotExists = IfNotExists() (indexName = Identifier())? Let's only have the index creation option that's consistent with the one above? https://asterix-gerrit.ics.uci.edu/#/c/1916/12/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java: PS12, Line 66: Override line break PS12, Line 190: BloomFilter Please file an issue and submit a separate change for this. The rest of the file seems to be only formatting changes, so I think that we can revert it. -- To view, visit https://asterix-gerrit.ics.uci.edu/1916 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Carey <dtab...@gmail.com> Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes