Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2096] Fix type casting for ExternalFunction ......................................................................
Patch Set 3: (1 comment) Can we move ResultExtractor changes into a separate change and add tests for it? https://asterix-gerrit.ics.uci.edu/#/c/2010/3/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java: Line 55: String results = ""; Minor. Since you're appending strings to 'results' it would be better to use StringBuilder or StringWriter here. -- To view, visit https://asterix-gerrit.ics.uci.edu/2010 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65c298def75b18fab01f513012e28fc44fdc2fd4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
