Ali Alsuliman has posted comments on this change. Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index ......................................................................
Patch Set 14: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1916/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java: Line 146: if (isPrimaryIndex || indexDataset.getDatasetType() == DatasetConfig.DatasetType.EXTERNAL || > Sounds good. Let's do it Done https://asterix-gerrit.ics.uci.edu/#/c/1916/14/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FixReplicateOperatorOutputsRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FixReplicateOperatorOutputsRule.java: Line 123: if (parentsPathToReplicate.contains(replicateOperator.getOutputs().get(oldParentIndex))) { > yes, deleting and then assigning real parents would be better. As for 'outp I'm not clear about your point regarding "outputMaterializationFlags". I am only setting the flag of one element of the array that corresponds to the special index. The other indexes do have the blocking sort operator. Isn't having one boolean that is applied to all expensive when we bulk load into a dataset that has multiple indexes? -- To view, visit https://asterix-gerrit.ics.uci.edu/1916 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Carey <dtab...@gmail.com> Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
