Michael Blow has posted comments on this change. Change subject: [NO ISSUE][RT] Abort All jobs on first time registration ......................................................................
Patch Set 3: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2026/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java: PS3, Line 109: LOGGER.log(Level.WARNING, "Failed getting hyracks dataset connection", e); : LOGGER.log(Level.WARNING, "Resetting hyracks connection"); combine into a single log message PS3, Line 117: ctx why ctx? might be clearer to synchronize on this PS3, Line 117: synchronized (ctx) { move to after 1st if (hds == null) (i.e. line 120) https://asterix-gerrit.ics.uci.edu/#/c/2026/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterResultPartitionLocationWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterResultPartitionLocationWork.java: PS3, Line 37: private final ClusterControllerService ccs; insert blank line to match convention? https://asterix-gerrit.ics.uci.edu/#/c/2026/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/AbortAllJobsWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/AbortAllJobsWork.java: PS3, Line 32: AbortAllJobsWork It seems we should only abort jobs started by the specific cluster controller, should we at least include some info in the work to indicate which CC it is, and call it something other than all? -- To view, visit https://asterix-gerrit.ics.uci.edu/2026 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If755b7131bdc91790ed28be66f0c61b51f28c2fa Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
