Hello Jenkins, I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/2010 to look at the new patch set (#5). Change subject: [ASTERIXDB-2096][COMP] Fix type casting for ExternalFunction ...................................................................... [ASTERIXDB-2096][COMP] Fix type casting for ExternalFunction - user model changes: no - storage format changes: no - interface changes: no Details: 1. The current IntroduceDynamicTypeCastForExternalFunctionRule cannot handle external function calls in nested record constructor. This patch fix this issue by visiting all nested parameters for external functions. 2. The ResultExtractor should be able to handle multiple queries in single statement file as AQL does. Change-Id: I65c298def75b18fab01f513012e28fc44fdc2fd4 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastForExternalFunctionRule.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java M asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/upperCase/upperCase.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/upperCase/upperCase.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/upperCase/upperCase.2.lib.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/upperCase/upperCase.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/upperCase/upperCase.4.lib.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/uppercase/uppercase.4.ddl.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/upperCase/upperCase.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_sqlpp.xml 10 files changed, 148 insertions(+), 31 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/10/2010/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/2010 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I65c298def75b18fab01f513012e28fc44fdc2fd4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>