Ildar Absalyamov has posted comments on this change. Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup ......................................................................
Patch Set 29: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2014/29/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponent.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponent.java: PS29, Line 124: : IChainedComponentBulkLoader createFilterBulkLoader() throws HyracksDataException; : : IChainedComponentBulkLoader createIndexBulkLoader(float fillFactor, boolean verifyInput, long numElementsHint, : boolean checkIfEmptyIndex) throws HyracksDataException; : : ChainedLSMDiskComponentBulkLoader createBulkLoader > we still need clear javadocs for those calls.... Done. Added comments to other interface methods. Let me know if I missed something -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 29 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov <ildar.absalya...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Ildar Absalyamov <ildar.absalya...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Wail Alkowaileet <wael....@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes