Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2128] Fix bloomfilter bug for primary index search ......................................................................
Patch Set 1: Interesting, and a good catch. I think maybe we need to consider carefully how we integrate the BloomFilters into the indices, since it seems fairly apparent what's in master right now isn't correct at all. Right now it's supposed to be part of the cursor but apparently that doesn't work at all. Pulling it into the LSM wrapped part seems straight forward enough, but I am still a bit uncertain of the consequence of this even after considering it for a while. -- To view, visit https://asterix-gerrit.ics.uci.edu/2070 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia065f73ae0c783dca70cd6cc9c6f0af8422bfcf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: No