Shiva Jahangiri has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON ......................................................................
Patch Set 23: (30 comments) https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java: Line 64: fmtString = > MAJOR SonarQube violation: Done Line 64: fmtString = > +1 Done Line 65: (fmtString.equalsIgnoreCase("JSON") || fmtString.equalsIgnoreCase("CLEAN_JSON")) > +1 Done Line 65: (fmtString.equalsIgnoreCase("JSON") || fmtString.equalsIgnoreCase("CLEAN_JSON")) > MAJOR SonarQube violation: Done Line 65: (fmtString.equalsIgnoreCase("JSON") || fmtString.equalsIgnoreCase("CLEAN_JSON")) > MAJOR SonarQube violation: Done Line 65: (fmtString.equalsIgnoreCase("JSON") || fmtString.equalsIgnoreCase("CLEAN_JSON")) > +1 Done https://asterix-gerrit.ics.uci.edu/#/c/1885/23/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java: Line 65: (fmtString.equalsIgnoreCase("JSON") || fmtString.equalsIgnoreCase("CLEAN_JSON")) > MAJOR SonarQube violation: Done Line 65: (fmtString.equalsIgnoreCase("JSON") || fmtString.equalsIgnoreCase("CLEAN_JSON")) > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: Line 115: private static final String lplan = "Logical plan"; > +1 I cannot change it cause this is what we write in <h4> Line 116: private static final String oplan = "Optimized logical plan"; > +1 I cannot change it cause this is what we write in <h4> https://asterix-gerrit.ics.uci.edu/#/c/1885/23/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java: PS23, Line 68: private > remove? Done PS23, Line 73: setId > remove? Done PS23, Line 77: getId > remove? Done https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java: PS22, Line 26: import org.apache.commons.lang3.mutable.Mutable; > Can you revert this file? It's not part of the change, really. Done https://asterix-gerrit.ics.uci.edu/#/c/1885/23/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java: PS23, Line 26: import > revert file? Done https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java: Line 24: import org.apache.commons.lang3.mutable.Mutable; > Same here. Done https://asterix-gerrit.ics.uci.edu/#/c/1885/23/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java: PS23, Line 24: apache > revert file? Done https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java: Line 97: private Stack<Integer> prefix; > MAJOR SonarQube violation: Done Line 118: stringPrefix = (stringPrefix.isEmpty()) ? val.toString() : stringPrefix + "." + val.toString(); > MAJOR SonarQube violation: Done Line 118: stringPrefix = (stringPrefix.isEmpty()) ? val.toString() : stringPrefix + "." + val.toString(); > +1 Done Line 121: String opId = (stringPrefix.isEmpty()) ? "" + (++id) : stringPrefix + "." + (++id); > MAJOR SonarQube violation: Done Line 121: String opId = (stringPrefix.isEmpty()) ? "" + (++id) : stringPrefix + "." + (++id); > MAJOR SonarQube violation: Done Line 121: String opId = (stringPrefix.isEmpty()) ? "" + (++id) : stringPrefix + "." + (++id); > +1 Done https://asterix-gerrit.ics.uci.edu/#/c/1885/23/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java: PS23, Line 74: HashMap > Should this be an IdentityHashMap? Done Line 97: private Stack<Integer> prefix; > MAJOR SonarQube violation: Done Line 97: private Stack<Integer> prefix; > +1 Done Line 118: stringPrefix = (stringPrefix.isEmpty()) ? val.toString() : stringPrefix + "." + val.toString(); > +1 Done Line 118: stringPrefix = (stringPrefix.isEmpty()) ? val.toString() : stringPrefix + "." + val.toString(); > MAJOR SonarQube violation: Done Line 121: String opId = (stringPrefix.isEmpty()) ? "" + (++id) : stringPrefix + "." + (++id); > MAJOR SonarQube violation: Done Line 121: String opId = (stringPrefix.isEmpty()) ? "" + (++id) : stringPrefix + "." + (++id); > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 23 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Shiva Jahangiri <shi...@uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
