Shiva Jahangiri has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON ......................................................................
Patch Set 22: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: Line 115: private static final String lplan = "Logical plan"; > Wait, what? We write the variable name? in line 161, we are printing the plan name that is either "Logical plan" or "Optimized logical plan" to the web interface and I needed to know which plan it is (logical/optimized logical) so I can set the correct class name in <pre>. what I was doing previously was: "Logical plan".equalsIgnoreCare(planName) which in a code review there was a suggestion to make this string finalized. -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 22 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Shiva Jahangiri <shi...@uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
